-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial support for importing compute clusters and modifying DRS #184
Conversation
I am not sure I can find time to finish this soon. I figured I would open a PR to gain visibility if someone was thinking of implementing this. Unfortunately, I am not able to create or delete clusters on the vSphere server I have access to. I have written an import function for others that might have a similar limitation. I started writing another resource to apply DRS suggestions but I am not sure what the interface looks like other than an "assertion" resource (there ought to be zero recommendations). The goal here was a Partially Automated DRS cluster where I control when the recommendations are run. |
Hey @jgensler8 - thanks for the PR! Compute clusters are on our roadmap, probably after v1.0.0 goes out sometime in November. I will keep this PR open here just so that we have the code as a reference or in case someone else wants to pick up the work. 👍 on supporting import too! Documentation would be great 😉 Applying DRS recommendations sounds like an interesting thing, and possibly something that I might be keeping in mind when we start work on the new PS: If you need a lab to develop against, you can set up a lab pretty "easy" if you can get your hands on vSphere doing nested ESXi on a single server node (this is actually what our lab is here). There is also the govmomi simulator, but YMMV on that one. Cheers! |
8ffa741
to
3a2fc92
Compare
3a2fc92
to
ff881ea
Compare
Hey @jgensler8 - just noticed that you have been updating this PR. Just FYI - now that #244 is completed, we will be setting eyes on this resource and a couple of others after getting v1.0.0 out. If you are still planning on working on this, I have a few requests:
If you could let me know how much you will be able to work on this as well going forward over the next month or so, that would be great. v1.0.0 is a few weeks out still, but after that, I will be looking at this resource a bit more in depth. Thanks! |
Hey @jgensler8, just FYI that we will be focusing on this for 1.5.0. More than likely we will take over development of this resource to get it completed at a standard we are comfortable with (but will build off of this work so contributions are preserved). Apologies for the radio silence and thanks for the work here! |
No worries, @vancluever. This has totally dropped off my radar. I don't think I'll find time to work on this resource and I think I'll close out this PR and wait for the feature to be added later. Thank you again for your communication along the way! You are doing great work with this provider! |
No problem @jgensler8 and thank you for the kind words! 🙂 |
No description provided.